Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CORS headers to git smart http protocol #5719

Merged
merged 5 commits into from
Jan 14, 2019
Merged

Support CORS headers to git smart http protocol #5719

merged 5 commits into from
Jan 14, 2019
+38 −18

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 13, 2019

should fix #5700

@lunny lunny added the type/enhancement An improvement of existing functionality label Jan 13, 2019
@codecov-io
Copy link

codecov-io commented Jan 13, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@5a081c7). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5719   +/-   ##
=========================================
  Coverage          ?   37.76%           
=========================================
  Files             ?      325           
  Lines             ?    47671           
  Branches          ?        0           
=========================================
  Hits              ?    18005           
  Misses            ?    27071           
  Partials          ?     2595
Impacted Files Coverage Δ
modules/setting/setting.go 48.8% <ø> (ø)
routers/repo/http.go 39.66% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a081c7...c09c4b6. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 13, 2019
zeripath
zeripath approved these changes Jan 13, 2019
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. It might be helpful to add something to the cheat sheet to explain what might be helpful to put here.

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 13, 2019
@lafriks
Copy link
Member

lafriks commented Jan 13, 2019

Also it should be warned that allowing cors from any site can be harmful from security point of view

@lunny
Copy link
Member Author

lunny commented Jan 14, 2019

@lafriks done.

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 14, 2019
@techknowlogick techknowlogick merged commit 270fa6d into go-gitea:master Jan 14, 2019
pbrackin pushed a commit to pbrackin/gitea that referenced this pull request Jan 15, 2019
@lunny
Support CORS headers to git smart http protocol (go-gitea#5719)
f6fb9aa
@JuhoHeiskanen JuhoHeiskanen mentioned this pull request Jan 23, 2019
Closed
7 tasks
@sapk sapk mentioned this pull request Aug 13, 2019
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@lunny lunny deleted the lunny/cors_http branch August 24, 2023 11:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support CORS headers to http receive-pack/send-pack like gogs
6 participants
@lunny @codecov-io @lafriks @techknowlogick @zeripath @bkcsoft